Skip to content

feat(smus): Update region selector to allow matching on region code#8324

Merged
laileni-aws merged 3 commits intoaws:feature/smusfrom
dylanraws:feature/smus-region-match
Nov 20, 2025
Merged

feat(smus): Update region selector to allow matching on region code#8324
laileni-aws merged 3 commits intoaws:feature/smusfrom
dylanraws:feature/smus-region-match

Conversation

@dylanraws
Copy link
Contributor

@dylanraws dylanraws commented Nov 19, 2025

Problem

When users sign in to SageMaker Unified Studio with IAM credentials, if they use the step-by-step wizard to add a new profile, when the user is prompted to select a region, typing in a region code such as us-east-1 to filter the results does not show expected results because the QuickPick matches only on the item labels, not on their description.

image

Solution

Update the region selection QuickPick to also match options according to the description (in addition to the label).

image

Tests are not necessary for this change, given that we are just changing a config option of the quick pick menu.

Not adding a changelog because this updates unreleased functionality in the feature/smus branch.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dylanraws dylanraws requested a review from a team as a code owner November 19, 2025 21:25
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@vpbhargav
Copy link
Contributor

/retryBuilds

## Problem

-
https://d1ihu6zq92vp9p.cloudfront.net/45451b0f-383e-4f4a-adc0-ce623f5765be/report.html
```
Error: Activating extension 'redhat.java' failed: Java 21 or more recent is required to run the Java extension. Please download and install a recent JDK. You can still compile your projects with older JDKs by configuring ['java.configuration.runtimes'](https://github.com/redhat-developer/vscode-java/wiki/JDK-Requirements#java.configuration.runtimes).
    at v.n (/tmp/.vscode-test/vscode-linux-x64-1.83.0/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:125:6274)
    at async v.m (/tmp/.vscode-test/vscode-linux-x64-1.83.0/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:125:6168)
    at async v.l (/tmp/.vscode-test/vscode-linux-x64-1.83.0/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:125:5625)
```

- The Python 3.14 version is coming from the external Serverless Land
repository pattern (aws-samples/serverless-patterns)
## Solution
- Fixed tests


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
@dylanraws dylanraws force-pushed the feature/smus-region-match branch from f8e0e92 to 205679f Compare November 19, 2025 23:53
@laileni-aws laileni-aws enabled auto-merge (squash) November 20, 2025 00:00
@laileni-aws laileni-aws merged commit 2a4e518 into aws:feature/smus Nov 20, 2025
50 of 52 checks passed
@dylanraws dylanraws deleted the feature/smus-region-match branch November 20, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants